[Webkit-unassigned] [Bug 24760] New: Clean up Position.h

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 23 09:18:34 PDT 2009


           Summary: Clean up Position.h
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Macintosh
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: HTML Editing
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: eric at webkit.org
                CC: darin at apple.com, justin.garcia at apple.com,
                    ojan at google.com, jparent at google.com

Clean up Position.h

I would like to make Position objects aware of the meaning of their container
and m_offset values.  This will require removing direct construction of
Positions objects.

Eventually positions will have the ability to specify [node, after], [node,
before] in addition to [node, childOffset].  Positions already have this
ability, but only for content which editing "ignores"
(editingIgnoresContent(node) returns true).  When editingIgnoresContent returns
true, then Positions [node, 0] and [node, 1] are interpreted as [node, before]
and [node, after] by some parts of the editing code, but not all.  you don't
actually know what type of position you're dealing with up-front, only in
certain places will [node, 0 (before)] be converted into [node->parentNode(),

I would like to fix positions to hide the details of m_offset and container
(which is not always really the "container" for the position, and add new
accessors to get that kind of information in a consistent way for all

Anyway, the first steps for this are to clean up Position objects to not make
m_offset and container public.  I'll attach patches to do this.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list