[Webkit-unassigned] [Bug 24719] QTMovieWinTimer logic inversion

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=24719


aroben at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #28798|review?(aroben at apple.com)   |review+
               Flag|                            |




------- Comment #5 from aroben at apple.com  2009-03-23 07:02 PDT -------
(From update of attachment 28798)
> +    } else if (message == WM_TIMER && wParam == timerID) {
> +        KillTimer(hWnd, timerID);
> +        timerID = 0;
> +        sharedTimerFiredFunction();
>      } else

Should we call stopSharedTimer here instead of duplicating its code?

It might be worth calling out that the bug fix here was the addition of the !
operator, since the other changes in the patch kind of obscure that fact.

r=me


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.