[Webkit-unassigned] [Bug 24586] maxDeepOffset is confusing and should be removed

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=24586


eric at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #28788|review?                     |review+
               Flag|                            |




------- Comment #15 from eric at webkit.org  2009-03-20 11:32 PDT -------
(From update of attachment 28788)
Justin reviewed this over IRC (from the shuttle).  

His comments:

some weird formatting in the change log

FIXED.

in the second line of the section that starts with "editing positions"
don't really need "deep"

I'm going to leave it for now.  The point was to identify that it was inside
the node if possible.  We can change it later (since this code is still very in
flux.)

the rest of the editing code will treat [img, 0]
+// as "the first position before the image"
just "the position before the image" i think

Will fix.

Thanks again Justin!


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.