[Webkit-unassigned] [Bug 23900] Crash if any frame in a frameset is named _top

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=23900


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #28786|review?                     |review-
               Flag|                            |




------- Comment #13 from darin at apple.com  2009-03-20 10:28 PDT -------
(From update of attachment 28786)
Thanks for tackling this.

I'm excited that you think we can make frames without names work properly. Are
you sure there are no new problems caused by removing the names? I believe we
use those frame names for back/forward housekeeping on Mac OS X at least. I'm
not sure it's safe to just throw that away.

What's your rationale for removing the disconnected frame feature? The fact
that _setIsDisconnected is in WebFramePrivate.h means that it’s SPI on Mac OS
X. So removing it would break Mac OS X applications that are using that API. So
you can’t just remove it. Did you remove it because you didn’t understand it or
because of some specific problem with it?

There’s no ChangeLog entry for WebCore. You need one.

The patch needs to include changes to test results for the tests that depend on
the old frame naming system, not just the new test.

There are tabs and a conflict marker in the LayoutTests/ChangeLog entry.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.