[Webkit-unassigned] [Bug 24586] maxDeepOffset is confusing and should be removed

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=24586





------- Comment #8 from justin.garcia at apple.com  2009-03-19 14:47 PDT -------
This is definitely the right direction.

-    if (startNode->renderer()
-        && ((startNode->renderer()->isTable() &&
!startNode->renderer()->isInline())
-            || startNode->renderer()->isHR())
-        && p.m_offset == maxDeepOffset(startNode))
-        return VisiblePosition(Position(startNode, 0));
+    if (renderedAsNonInlineTableOrHR(startNode->renderer()) &&
p.atEndOfNode())
+        return firstPositionInNode(startNode);

That said, I think that  "atEndOfNode" is inaccurate.  [hr, 1] is demonstrative
of this.  [hr, 1] isn't at the "end of" the hr, it's after it.  Same for a
table, an image, etc.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.