[Webkit-unassigned] [Bug 24689] Upstream V8 bindings for Workers proxies.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=24689


dglazkov at chromium.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #28758|review?                     |review-
               Flag|                            |




------- Comment #6 from dglazkov at chromium.org  2009-03-19 13:49 PDT -------
(From update of attachment 28758)
We're very, very close! One more round of bathing, as eseidel used to say, and
we're home.

> +    v8::HandleScope scope;
> +    v8::Persistent<v8::Object> wrapper = GetDOMObjectMap().get(m_workerContext);
> +    if (!wrapper.IsEmpty())
> +        V8Proxy::SetDOMWrapper(wrapper, V8ClassIndex::INVALID_CLASS_INDEX, NULL);
> +    GetDOMObjectMap().forget(m_workerContext);

domObjectMap
> +
> +    // Insert the object instance as the prototype of the shadow object.
> +    v8::Handle<v8::Object> v8_global = m_context->Global();
> +    v8_global->Set(implicitProtoString, jsWorkerContext);
> +}

global or globalObject

> +    // Non DOM node
> +    v8::Persistent<v8::Object> result = GetDOMObjectMap().get(impl);

domObjectMap

> +    v8::Handle<v8::Object> wrapper = GetDOMObjectMap().get(event);

domObjectMap

> +    if (GetDOMObjectMap().contains(event)) {
> +        GetDOMObjectMap().forget(event);

getDOMObjectMap


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.