[Webkit-unassigned] [Bug 24592] [GTK] Crash in FcPatternHash

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=24592


zecke at selfish.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #28682|review?                     |review+
               Flag|                            |




------- Comment #9 from zecke at selfish.org  2009-03-17 07:25 PDT -------
(From update of attachment 28682)

> +    // Do this first, since we need to catch self assignment.
> +    if (m_fallbacks && !(*this == other)) {

okay, we don't want to go through the operator== of this class but really
compare the pointers of this and &other. You might want to consider having if
(this == &other)\ return *this; at the top but this would optimize for the
unlikely case... at least change it to compare the pointers as discussed on
irc.


> -    if (m_font.m_pattern && ((FcPattern*)-1 != m_font.m_pattern)) {

we don't do the -1 check in the assignment operator and it seems fine. So let
us schedule this bit for removal too (later patch or might be proven wrong if
the assignment is crashing).



regarding the pango backend. we should update it too, it is needed for users on
OSX (native/framework) and win32...


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.