[Webkit-unassigned] [Bug 24588] Update media element implementation to current spec

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 17 00:23:46 PDT 2009


adele at apple.com changed:

           What    |Removed                     |Added
  Attachment #28645|review?                     |review-
               Flag|                            |

------- Comment #5 from adele at apple.com  2009-03-17 00:23 PDT -------
(From update of attachment 28645)
Looks pretty good.  Minor comments below.  I found a problem with this patch
and the load event on Windows.  Eric's going to diagnose tomorrow, so I'll r-
this for now, but I expect this will be ready to check in fairly soon once that
issue is figured out.

> Index: WebCore/ChangeLog
typo "obsolute"
typo "ticke"

> Index: WebCore/html/HTMLMediaElement.cpp
> ===================================================================

I think it would be cleaner here to remove the commented out code, and stick it
in a bug.  Then you can just reference the bug here.

> +    // FIXME: don't schedule timeupdate or progress events unless there are registered listeners
> +/*
> +    if (eventType == eventNames().progressEvent && !document()->hasListenerType(Document::xxxxxx_LISTENER))
> +        return;
> +    if (eventType == eventNames().timeupdateEvent && !document()->hasListenerType(Document::xxxxxx_LISTENER))
> +        return;
> +*/
> +

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list