[Webkit-unassigned] [Bug 24592] [GTK] Crash in FcPatternHash

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=24592


xan.lopez at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #28653|                            |review?
               Flag|                            |




------- Comment #3 from xan.lopez at gmail.com  2009-03-16 11:56 PDT -------
Created an attachment (id=28653)
 --> (https://bugs.webkit.org/attachment.cgi?id=28653&action=view)
gtkfonts.patch

This patch makes FontPlatformDataGtk free the memory it allocates in its own
destructor, instead of having SimpleFontDataGtk free it in platformDestroy.
Also, since the class has reference counted members we need a copy constructor
and '=' operator to properly track those references when assigning and copying
objects. With these two changes I can't reproduce the crash anymore.

Holger said he was concerned this might be a performance regression, but: other
ports have objects that they also have to copy in their FontPlatformData*
classes, so I don't see how this is that different. Besides, what this does is
to add two extra refcounts per copy, it does not do actual copies of the fc
pattern or the cairo fonts. That being said, there might be better ways to
handle this, so I'm totally open to comments :)


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.