[Webkit-unassigned] [Bug 24456] Chromium Unforking: Split ColorChromium.cpp into Windows + Mac variants

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=24456


darin at chromium.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #28477|review?                     |review-
               Flag|                            |




------- Comment #7 from darin at chromium.org  2009-03-15 08:40 PDT -------
(From update of attachment 28477)
>+++ b/WebCore/ChangeLog
>+2009-03-11  Jeremy Moskovich  <jeremy at chromium.org>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Split ColorChromium.cpp into Mac & Windows variants.
>+        Remove Chromium Dependency on platform/graphics/mac/ColorMac.mm since we
>+        ultimately need to take a different approach.  For now, createCGColor()
>+        is copied from ColorMac.mm.
>+
>+        No observable change in behavior, so no test.

nit: please add a bug link in here.


>+
>+        * platform/graphics/chromium/ColorChromium.cpp:
>+        (WebCore::focusRingColor):
>+        * platform/graphics/chromium/ColorChromiumMac.mm: Added.
>+        (WebCore::focusRingColor):
>+        (WebCore::nsColor):
>+        (WebCore::CGColorFromNSColor):
>+        (WebCore::createCGColor):

nit: for newly added files, please remove the lines that mention the newly
added
functions.  i wish prepare-ChangeLog did that automatically :-/


>+++ b/WebCore/platform/graphics/chromium/ColorChromiumMac.mm
>@@ -0,0 +1,131 @@
>+/*
>+ * Copyright (C) 2008 Google Inc. All rights reserved.

This copyright info is not correct, right?


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.