[Webkit-unassigned] [Bug 24593] Minor renaming in Chromium port's ResourceRequest.h

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=24593


darin at chromium.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #28612|review?                     |review-
               Flag|                            |




------- Comment #2 from darin at chromium.org  2009-03-13 16:45 PDT -------
(From update of attachment 28612)
>Index: WebCore/ChangeLog
...
>+2009-03-13  jabdelmalek  <set EMAIL_ADDRESS environment variable>

nit: need to add your email address.  also good to put your full name.

you can set the env vars REAL_NAME and EMAIL_ADDRESS to make this
automatic next time you run prepare-ChangeLog.

>+        Reviewed by NOBODY (OOPS!).
>+
>+		https://bugs.webkit.org/show_bug.cgi?id=24593
>+
>+		Added requestorID so we can track the request to its WebView without using frame (which was removed).
>+

nit: tabs need to be replaced with spaces


>Index: WebCore/platform/network/chromium/ResourceRequest.h
...
>+            , m_requestorID(0)
>+            , m_requestorPid(0)

webkit style would make this m_requestorPID, but even better (I think)
would be to go with m_requestorProcessID.  that way it is not as visually
confusing with m_requestorID.  verbose names is consistent with webkit
style ;-)


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.