[Webkit-unassigned] [Bug 24584] Translucent text rendering on Chromium is broken

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=24584





------- Comment #10 from brettw at chromium.org  2009-03-13 15:34 PDT -------
(From update of attachment 28603)
> Index: WebCore/platform/graphics/chromium/TransparencyWin.h
> ===================================================================
> --- WebCore/platform/graphics/chromium/TransparencyWin.h	(revision 41685)
> +++ WebCore/platform/graphics/chromium/TransparencyWin.h	(working copy)
> @@ -134,6 +134,9 @@ public:
>                TransformMode transformMode,
>                const IntRect& region);
>  
> +    // Combines the source and destination bitmaps using the given mode.
> +    void composite();

You should comment on the conditions where this is function is required. Which
layer modes is it required for? Also, the comments for those layer modes should
say that calling composite before destruction is required.

Second, now that this is required, it needs to be called in the other places
that TransparencyWin is used. This is RenderThemeChromiumWin as well as
webkit/tools/webcore_unit_tests/TransparencyWin_unittest.cpp in Chrome. I think
that it will assert in both places otherwise.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.