[Webkit-unassigned] [Bug 24538] class/struct mixup in forward declarations

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 13 10:45:31 PDT 2009


------- Comment #3 from norbert.leser at nokia.com  2009-03-13 10:45 PDT -------
(In reply to comment #2)
> (From update of attachment 28514 [review])
> The ResourceRequest change isn't obviously correct, as ResourceRequest is
> declared as a struct on some platforms, but class on others.  That should
> probably be made consistent as there's a chance that changing it from class to
> struct will break other platform's builds.
I understand that this could potentially be an issue with other platforms.
However, apparently it is not, because ResourceRequest is forward declared both
as class and as struct across WebCore (e.g., xml/XMLHttpRequest.h,
network/ResourceHandleClient.h, ... use struct). There are only 2 non-platform
specific places where it is declared as "class". I suggest to make it
consistent throughout WebCore.
-- One place is in loader/appcache/ApplicationCache.h, as proposed in my patch.
-- The 2nd place is wml/WMLGoElement.h. That's not included in my patch because
I don't have the means of regression testing that code path. Still, if you can
verify that, it would be cleaner to also make that change.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list