[Webkit-unassigned] [Bug 22898] [GTK] Patch to complete GtkPrint API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=22898





------- Comment #22 from colin at colino.net  2009-03-12 11:00 PDT -------
(In reply to comment #21)

> > See comment #14...
> 
> OK, what I read there is that we should not be exporting different public APIs
> depending on GTK+ version. This makes perfect sense, but it doesn't mean we
> _need_ to support older GTK+ versions. I believe we can focus on gtk > 2.10
> from now on, if nobody objects to it for some reason.

Yes, that's what the patch does (and stock Webkit too): just a g_warning when
trying to print on GTK < 2.10.

> Yeah, I think we need to have more API users comment on this, but I'll be glad
> to write a patch later this month, if need be =). 

OK, great :) The size of Webkit's source code makes it painful to maintain my
patch locally, and handle it cleanly against my package manager, so I'd love to
have some way to do what I need upstream - even if it means rewriting 10-50
lines of my own code :)


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.