[Webkit-unassigned] [Bug 22898] [GTK] Patch to complete GtkPrint API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=22898





------- Comment #20 from colin at colino.net  2009-03-12 01:27 PDT -------
(In reply to comment #19)

> > I've been specifically asked for GTK < 2.10 support (or rather API
> > compatilibity). It doesn't add much to the patch.
> 
> By who? With what rationale? It's just a small amount of code, indeed, but I am
> not convinced we need it at all.

See comment #14...

> I think passing a GtkPrintOperation, really, much in the same way the
> create-web-view does with WebKitWebView. I am worried that we limit the amount
> of control the application has regarding the printing process - for instance,
> displaying progress.
> 
> > [...]
> 
> Right. The way I understand this, though, ChromeClient::print may be called by
> javascript code requesting printing, for instance. The current implementation
> will popup the print dialog if this happens, which may not be what the
> application intends - it may just as well want to print to a file
> automatically, with an automatically-generated name, or send the job with a
> pre-defined configuration to a pre-defined printer.
> 
> Coupled with my worries about the amount of control the application is able to
> have regarding the printing process as a whole, I wonder if adding a
> print-requested signal or something like that, which expects the client to give
> it an already setup GtkPrintOperation is not the way to go.

It may be good to have an "official" view on this from Webkit's team. 

Anyway, I lack time to go through complete rewrites of this patch. If the
Webkit developers prefer your way of doing, I'll let you write the patch :)


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.