[Webkit-unassigned] [Bug 24485] Fix Chromium http/tests/security/dataURL/xss-DENIED-* layout tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 9 23:39:05 PDT 2009


scherkus at chromium.org changed:

           What    |Removed                     |Added
  Attachment #28429|                            |review?
               Flag|                            |

------- Comment #1 from scherkus at chromium.org  2009-03-09 23:39 PDT -------
Created an attachment (id=28429)
 --> (https://bugs.webkit.org/attachment.cgi?id=28429&action=view)
DOMWindow.idl patch

I ran all layout tests with and without the patch and saw no regressions.

I'm a bit wary of this patch because it *does* affect all builds (it inserts a
checkNodeSecurity in JSC's JSDOMWindow document getter), so I'm open to ideas
if anyone else knows how to insert a node security check.

I couldn't find how WebKit passes the tests without the CheckNodeSecurity.  I'm
almost wondering if there is some duplicated logic or custom binding code
written somewhere that this patch could help remove.

The failing tests for Chromium V8 in particular are:

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list