[Webkit-unassigned] [Bug 24349] [Qt] HTTP status text is never set

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 9 02:31:05 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=24349





------- Comment #5 from adam.bergkvist at ericsson.com  2009-03-09 02:31 PDT -------
(In reply to comment #3)
> (From update of attachment 28263 [review])
> 
> > +        response.setHTTPStatusText(m_reply->attribute(QNetworkRequest::HttpReasonPhraseAttribute).toByteArray().constData());
> 
> this is weird...
> QString -> QByteArray -> constData -> String when we have a QString -> String
> already...
> 

m_reply->attribute(QNetworkRequest::HttpReasonPhraseAttribute) is a
QVariant::ByteArray. We could do a toString() to construct a QString, but that
would cause an extra copy of the character data.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list