[Webkit-unassigned] [Bug 24150] Add virtual ScriptExecutionContext::encoding()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 6 01:58:47 PST 2009


ap at webkit.org changed:

           What    |Removed                     |Added
  Attachment #28345|review?                     |review+
               Flag|                            |

------- Comment #13 from ap at webkit.org  2009-03-06 01:58 PDT -------
(From update of attachment 28345)
Thanks, that's very useful information! Much of the Gecko behavior looks like
it may be unintentional indeed - would you be willing to file bugs with
Mozilla? It could also be worth discussing this with WHATWG.

-    // FIXME: does this need to provide a charset, like Document::completeURL
+    // Note Document::completeURL provides a charset here (to encode query
portion of url when
+    // submitting charset-encoded forms data). Workers always use UTF-8 which
is default for KURL.
     return KURL(m_location->url(), url);

I think that the word "Note" is extraneous here - it's a comment, after all.
Per your research, it is not clear that we'll want this behavior forever, given
that Firefox uses document encoding for Worker and importScripts() URL
completion. So, the FIXME still seems appropriate, perhaps amended with results
of your research.


Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list