[Webkit-unassigned] [Bug 24400] Remove "start", "end", "loopStart", "loopEnd", "currentLoop", and "playCount" media element attributes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=24400


simon.fraser at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #28322|review?                     |review+
               Flag|                            |




------- Comment #2 from simon.fraser at apple.com  2009-03-05 13:41 PDT -------
(From update of attachment 28322)

>  2009-03-04  Simon Fraser  <simon.fraser at apple.com>
>  
>          Rubber-stamped by Eric Seidel.

Lots of removed changelogs here.

> Index: LayoutTests/media/video-loop-expected.txt
> ===================================================================
> +EXPECTED (media.currentTime == '8.399999618530273') OK

Seems like this might be sensitive to platform floating point rounding issues.
Is there a more reliable way to test it?

> Index: LayoutTests/media/video-seek-past-end-paused-expected.txt
> ===================================================================
> --- LayoutTests/media/video-seek-past-end-paused-expected.txt	(revision 41447)
> +++ LayoutTests/media/video-seek-past-end-paused-expected.txt	(working copy)
> @@ -1,9 +1,18 @@
>  Test that seeking paused video past it's duration time sets currentTime to duration and leaves video paused.
>  
> +RUN(video.src = 'content/test.mp4')
>  RUN(video.load())
> +
>  EVENT(load)
> -RUN(video.currentTime = 500)
> -EVENT(timeupdate)
> -EXPECTED (video.currentTime == '8.399999618530273') OK
> +EXPECTED (video.paused == 'true') OK
> +EXPECTED (video.ended == 'false') OK
> +RUN(video.play())
> +
> +EXPECTED (video.paused == 'false') OK
> +EXPECTED (media.currentTime > '0') OK
> +
> +EXPECTED (video.ended == 'true') OK
> +EXPECTED (media.currentTime == '8.399999618530273') OK

Ditto.

r=me if you address those issues.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.