[Webkit-unassigned] [Bug 24389] New: WebKitGTK+ crashes when cancelling plugin loads

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=24389

           Summary: WebKitGTK+ crashes when cancelling plugin loads
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Linux
            Status: NEW
          Keywords: Gtk, Soup
          Severity: Normal
          Priority: P2
         Component: WebKit Gtk
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: gns at gnome.org


If you go to a page that uses plugins such as flash, and click a link or cancel
the load, the browser will crash. Investigating the problem I found out that
our ResourceHandle implementation calls didFinishLoading in it's cancel method,
which is completely bogus, the way I understand the workflow, and is not done
by any other ports except for the Windows
(WebCore/platform/network/win/ResourceHandleWin.cpp) port.

I made a patch removing the calls to didFinishLoading, and tested with acid2,
acid3, and the webkit layout tests, and found no regression. The crash is also
gone.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.