[Webkit-unassigned] [Bug 24342] Cannot insert a Thai character after a Thai prepend character when using ICU 4.0

Thu Mar 5 06:38:17 PST 2009

https://bugs.webkit.org/show_bug.cgi?id=24342

ap at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #28262|review?                     |
               Flag|                            |

------- Comment #7 from ap at webkit.org  2009-03-05 06:38 PDT -------
(From update of attachment 28262)
I've now built a local copy of ICU 4.0.1, and I can reproduce this problem in
Safari with it. I think that the approach in this fix is absolutely correct.

Instead of inputCursorIterator, I'd say "cursorMovementIterator" - it is not
directly related to input, as it will be used for e.g. selecting non-editable
text.

Looking over other uses of characterBreakIterator in WebCore, I noticed another
case that might be incorrect, which is in
CoreTextController::offsetForPosition(). It's better to handle it separately
though.

Clearing review flag for now, as you said that you were going to submit a new
patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.