[Webkit-unassigned] [Bug 24291] REGRESSION (r38592-r38645): Single line JavaScript comment prevents HTML button click handler execution

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=24291


cwzwarich at uwaterloo.ca changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|webkit-                     |cwzwarich at uwaterloo.ca
                   |unassigned at lists.webkit.org |




------- Comment #5 from cwzwarich at uwaterloo.ca  2009-03-03 20:50 PDT -------
This is the problem, at the top of constructFunction() in
FunctionConstructor.cpp:

    UString program;
    if (args.isEmpty())
        program = "(function(){})";
    else if (args.size() == 1)
        program = "(function(){" + args.at(exec, 0).toString(exec) + "})";
    else {
        program = "(function(" + args.at(exec, 0).toString(exec);
        for (size_t i = 1; i < args.size() - 1; i++)
            program += "," + args.at(exec, i).toString(exec);
        program += "){" + args.at(exec, args.size() - 1).toString(exec) + "})";
    }

This is possibly incorrect when anything in the middle has a single-line
comment. The fix is to add newlines after substitutions.

I'll assign this to myself.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
You are the assignee for the bug, or are watching the assignee.