[Webkit-unassigned] [Bug 23932] Current API does not allow us to open target="_blank" links in new tabs instead of windows

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=23932





------- Comment #5 from alex at igalia.com  2009-03-03 14:06 PDT -------
(In reply to comment #3)
> (From update of attachment 28066 [review])
> Thanks for working on this; a much needed fix =).
> 
> > +static GObject *getNavigationAction(const NavigationAction& action)
> 
> The * should be close to the type here. Why not use WebKitNavigationAction
> here, instead of GObject, by the way? It would look more correct to me, and
> it's not like you're saving on casts by using GObject, right?
> 

Yes, saving casts was not my intention (actually I'm seeing an unnecesary
G_OBJECT cast :), the only reason to use Gobject it was reuse the old code of
the function as it was. I agree with your proposal.

Thanks for the review.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.