[Webkit-unassigned] [Bug 22634] Safari crashes when I try to do a drag-and-drop of selected text in Presently or Writely,

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 2 12:54:52 PST 2009


https://bugs.webkit.org/show_bug.cgi?id=22634





------- Comment #4 from sky at google.com  2009-03-02 12:54 PDT -------
Adding:

            if (!startOfParagraphToMove.deepEquivalent().node()->parent()) {
                // Inserting the break resulted in deleting the node we're
going to move.
                return;
            }

Right after:

        if (startOfParagraph(endOfInsertedContent) == startOfParagraphToMove) {
            insertNodeAt(createBreakElement(document()).get(),
endOfInsertedContent.deepEquivalent());

In ReplaceSelectionCommand fixes the bug, but when attempting to drag the third
time a different crash occurs.

Seems to me any place in ReplaceSelectionCommand that does mutation needs to
make sure the document is sane before continuing. This is based on my limited
knowledge of webkit though, so I could of course be completely wrong.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list