[Webkit-unassigned] [Bug 24283] New: QWebPage::acceptNavigationRequest type is not QWebPage::NavigationTypeReload when QWebPage::reload() is called

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=24283

           Summary: QWebPage::acceptNavigationRequest type is not
                    QWebPage::NavigationTypeReload when QWebPage::reload()
                    is called
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Mac OS X 10.5
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: WebKit API
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: ben at meyerhome.net


After calling QWebPage::reload() QWebPage::acceptNavigationRequest() is called,
but the type is not WebPage::NavigationTypeReload, but is QWebPage::Other

In FrameLoader.cpp FrameLoader::reload should it always call
setTriggeringAction()?  Currently it is only calling it if request.httpMethod()
== "POST".  This causes dispatchDecidePolicyForNavigationAction to to only now
that it is a reload when it is a post.

Below it the initial patch that solves this.  If this is correct I can turn
this into a proper patch.

--- a/src/3rdparty/webkit/WebCore/loader/FrameLoader.cpp
+++ b/src/3rdparty/webkit/WebCore/loader/FrameLoader.cpp
@@ -2456,9 +2456,10 @@ void FrameLoader::reload(bool endToEndReload)
     // If we're about to re-post, set up action so the application can warn
the user.
     if (request.httpMethod() == "POST")
         loader->setTriggeringAction(NavigationAction(request.url(),
NavigationTypeFormResubmitted));
+    else
+        loader->setTriggeringAction(NavigationAction(request.url(),
+                    endToEndReload ? FrameLoadTypeReloadFromOrigin :
FrameLoadTypeReload, 0));

     loader->setOverrideEncoding(m_documentLoader->overrideEncoding());
     loadWithDocumentLoader(loader.get(), endToEndReload ?
FrameLoadTypeReloadFromOrigin : FrameLoadTypeReload, 0);
 }


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.