[Webkit-unassigned] [Bug 17585] [gtk] get|set encoding api

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=17585





------- Comment #15 from christian at twotoasts.de  2009-03-01 16:02 PDT -------
(In reply to comment #14)
> (In reply to comment #9)
> > (In reply to comment #8)
> > > Created an attachment (id=28034)
 --> (https://bugs.webkit.org/attachment.cgi?id=28034&action=view) [review] [review] [review]
> > > Add _get_encoding and properties
> > 
> > Meanwhile I implemented menu items for this to properly test the patch.
> > _get_encoding seems to return the custom encoding, ie. loader()->encoding()
> > actually has the custom value after the custom encoding set for the first time.
> > I'm not sure yet how to overcome this.
> > 
> 
> If this is really the case it might make sense to just have one function,
> get_encoding, and another one to check whether or not the encoding is automatic
> or forced by the user. Not much sense in having two getters that return the
> same thing, I think.

Well, it's not expected to make any sense, it's a bug afterall. As we
discussed, the API should allow for seeing the default encoding even if it was
overridden.

To me it looks like a bug in WebCore at this point, but I have to give that a
closer look since I'm not familiar with where that's coming from. Otherwise we
need to workaround it in WebKit I guess.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.