[Webkit-unassigned] [Bug 23707] [gtk] resizing plugins does not work, because the plugin never gets informed

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=23707


xan.lopez at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |xan.lopez at gmail.com




------- Comment #5 from xan.lopez at gmail.com  2009-03-01 04:24 PDT -------
(In reply to comment #4)

Hi, there's a few style issues in your patch:

- No ChangeLog: you need to generate one using the script ot
WebKitTools/Scripts/prepare-ChangeLog.

- It seems the patch does at least two more or less unrelated cleanups/fixes,
maybe it would be nice to split it...

+    // sanity check
+    if (! m_plugin->pluginFuncs()->event)
+        return false;

No space between '!' and m_plugin...

 void PluginView::setNPWindowRect(const IntRect& rect)
 {
-    if (!m_isStarted || !parent())
-        return;
-
-    IntPoint p =
static_cast<FrameView*>(parent())->contentsToWindow(rect.location());
-    m_npWindow.x = p.x();
-    m_npWindow.y = p.y();
-
-    m_npWindow.width = rect.width();
-    m_npWindow.height = rect.height();
-
-    m_npWindow.clipRect.left = 0;
-    m_npWindow.clipRect.top = 0;
-    m_npWindow.clipRect.right = rect.width();
-    m_npWindow.clipRect.bottom = rect.height();
+    setNPWindowIfNeeded();
+}

Since this does not use the parameter anymore you should change it to 'const
IntRect&', lose the name.

-    } else if (m_isWindowed)
+    } else if (m_isWindowed) {
        
setPlatformWidget(gtk_xtbin_new(m_parentFrame->view()->hostWindow()->platformWindow()->window,
0));
+    }

No braces for one-line control clauses.

If you can update it and mark it for review (select '?' in the review combobox
when uploading the patch), I'll try to get someone familiar with this to have a
look at it. Thanks!


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.