[Webkit-unassigned] [Bug 26854] [GTK] Needs API to allow more control over outgoing requests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26854





------- Comment #6 from gns at gnome.org  2009-06-30 18:55 PDT -------
(In reply to comment #5)
> > +    WebKitWebView* webView = getViewFromFrame(m_frame);
> > +    WebKitNetworkRequest* networkRequest = webkit_network_request_new_with_core_request(request);
> > +
> > +    g_signal_emit_by_name(webView, "outgoing-request", m_frame, identifier, networkRequest);
> 
> We probably need to send the data source object as well and possibly make
> identifier an attribute of that object.

I don't think there's a data source object here yet, is there? I think we may
want to keep the identifier out of any objects.

> As for naming, I'm not sure what outgoing-request means. I think it needs to be
> more meaningful.

We need a way of expressing 'a request is going to be sent', outgoing-request
was the first thing I could think of.

> > +     * Emitted when a request is about to be sent. You can modify the
> > +     * request, by adding/removing/replacing headers, or changing the
> > +     * URI, using the #SoupMessage object it carries, if it is
> 
> Will changing the URI have any effect on security?

It could, so it's best that the application know what it is doing =).

> The marshaller seems to be off here.

danw pointed that out, thanks =)

> Also, the DRT support for this is missing + the layout tests that will be
> enabled by this feature.

What kind of DRT support, do you mean? I don't think we will have layout tests
enabled by this feature, too. This is purely API-related, AFAIK.

> 
> r- for now because of this.
> 


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.