[Webkit-unassigned] [Bug 26821] REGRESSION(r45285): focus rings are black on windows safari

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26821





------- Comment #14 from aroben at apple.com  2009-06-30 16:33 PDT -------
(In reply to comment #13)
> (In reply to comment #11)
> > (2) (In reply to comment #8)
> > > 2) Add a call to set a custom focus ring color. Safari would call this, passing
> > > the focus ring color from SafariTheme.
> > 
> > so this has to run through RenderThemeWin::focusRingColor, doesn't it?
> > When the focusRingColor is asked for in
> > CSSSylteSelector::getColorFromPrimitiveValue(), as of r45285, the defaultTheme
> > is asked to provide this color. 
> > 
> > as (2) is described i'm confused how RenderThemeWin::focusRingColor will play
> > its role.  
> 
> getColorFromPrimitiveValue could be the place where the custom color is
> retrieved. If no custom color is specified, then it would ask the defaultTheme.
> Doing it this way would make it work for all platforms, and maybe could replace
> Chromium's special test mode flag.

Another option would be to move the implementation of focusRingColor into the
base RenderTheme class. That function would basically do:

return customFocusRingColor ? customFocusRingColor : platformFocusRingColor()

And platformFocusRingColor() would do exactly what focusRingColor() does today.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.