[Webkit-unassigned] [Bug 26821] REGRESSION(r45285): focus rings are black on windows safari

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 30 16:29:33 PDT 2009


eric at webkit.org changed:

           What    |Removed                     |Added
                 CC|                            |fishd at chromium.org

------- Comment #12 from eric at webkit.org  2009-06-30 16:29 PDT -------
I would think we could make Chromium's "custom focus ring color" implementation
more general to cover this case:

5       Color RenderThemeChromiumMac::focusRingColor() const 
        176     { 
        177         if (ChromiumBridge::layoutTestMode()) 
        178             return oldAquaFocusRingColor(); 
        180         return systemColor(CSSValueWebkitFocusRingColor); 
        181     } 

But maybe I'm over-engineering the problem here.  Chromium could certainly
change to call a special "set custom focus ring color" perference instead of
having a ChromiumBridge method to check "testing mode".

I think to fix the regression it's easiest to add "custom focus ring color"
support just to RenderThemeWin.  Someone else can come back and make it more
general in a second pass.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list