[Webkit-unassigned] [Bug 26457] Build DumpRenderTree under Cairo

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26457


bfulgham at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED




------- Comment #6 from bfulgham at webkit.org  2009-06-30 13:42 PDT -------
(In reply to comment #3)
> (From update of attachment 31577 [review])
> This part should all be shared:
> 93     // We need to swap the bytes to ensure consistent hashes independently
> of endianness
>  94     MD5_CTX md5Context;
>  95     MD5_Init(&md5Context);

I tried to share this, but this routine in shared between Cairo, CG (Windows),
and CG (Mac).  On CG (Mac) there are some additional checks and endian handling
that change the structure of this function a bit.

For now, I'd prefer to leave this alone (all CG share one version, Cairo uses
another), at least until I can start getting some build and run feedback from
GTK users to determine if similar endianness logic is warranted.

Otherwise, I have made the changes you suggested.

I've also tested the Mac version with these changes and confirmed it works
properly on the LayoutTests.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.