[Webkit-unassigned] [Bug 26590] Support for String.trim(), String.trimLeft() and String.trimRight() methods

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26590





------- Comment #20 from ioseb.dzmanashvili at gmail.com  2009-06-30 07:59 PDT -------
(In reply to comment #19)

Hi Eric,

Thank you for response.

> My question would be why should isStrWhiteSpace not respect 0x200b?  If it
> should then we should just change isStrWhiteSpace.

I'm not sure about this... I don't know if "0x200b" should be included in
isStrWhiteSpace function's implementation. I took these characters from Ecma
3.1 proposal for String.trim();

Here is the link to the PDF document:
http://wiki.ecmascript.org/lib/exe/fetch.php?id=es3.1%3Atargeted_additions_to_array_string_object_date&cache=cache&media=es3.1:es31_stringobject.pdf

Source:
http://wiki.ecmascript.org/doku.php?id=es3.1:targeted_additions_to_array_string_object_date

> If it shouldn't, then you
> should add your own function:
> 
> static inline bool isTrimableWhiteSpaceChar(int c)
> {
>     return isStrWhiteSpace(c) || c == 0x200b; // zero width space
> }

Decision is up to you, I just need to know what to do next. I'm waiting for
response and I'll upload patch immediately.

Thank you again.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.