[Webkit-unassigned] [Bug 25889] [GTK] scrollbar policy for main frame is not implementable

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25889





------- Comment #38 from jmalonzo at gmail.com  2009-06-30 07:06 PDT -------
(From update of attachment 32028)
> +        (WebCore::ScrollView::setScrollbarModes):
> +>>>>>>> report scrollbar policy:WebCore/ChangeLog

Something went wrong here.

> +    GtkWidget* parent = gtk_widget_get_parent(GTK_WIDGET(webView));
> +    if (!parent || !GTK_IS_SCROLLED_WINDOW(parent))
> +        return;

Should this be an &&?

> +    /* Never */

Never?

> +    /* Always */

Is it ok to be more descriptive? :)

> +    /* Auto */

Ditto.

> +     * @web_view: the object which received the signal
> +     *
> +     * Signal emitted when policy for one or both of the scrollbars of
> +     * the view has changed. The default handler will apply the new
> +     * policy to the container that holds the #WebKitWebFrame if it is
> +     * a #GtkScrolledWindow. If you do not want this to be handled
> +     * automatically, you need to handle this signal.

What does the last sentence mean? 

> +     * Determines the current policy for the horizontal scrollbar of
> +     * the frame. For the main frame, make sure to set the same policy
> +     * on the scrollable widget containing the #WebKitWebView, unless
> +     * you know what you are doing.

What happens if they don't set the same policy in the widget containing the
WebView? I think it should mention it here too.

The rest looks fine. I'll let Holger do the r+ as he's more familiar with it
(and it's in his todo list :)


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.