[Webkit-unassigned] [Bug 26827] New: Improve InlineBox::first/lastLeafChild methods

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26827

           Summary: Improve InlineBox::first/lastLeafChild methods
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Minor
          Priority: P4
         Component: WebCore Misc.
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: rolandsteiner at google.com


The current methods have some peculiarities (the following also all apply to
the corresponding lastLeafChild[BeforeBox]() method):

.) someBasePtr->firstLeafChild() may return the same node rather than a child
node

.) someBasePtr->firstLeafChild[AfterBox]() may return a node outside of the
subtree

.) the meaning of someBasePtr->firstLeafChildAfterBox(), i.e., without
parameter, is unclear without reading the code. It's also synonymous with
firstLeafChild. It's also unclear why the method would need both a 'this'
pointer AND a parameter (both issues are likely just artifacts of the
implementation). 

.) from an interface POV there doesn't seem to be a reason why
firstLeafChildAfterBox() should be restricted to InlineFlowBox (rather than be
available on InlineBox)

.) The behavior of firstLeafChild[AfterBox]() is quadratic if the remaining
nodes in the tree after the given box are all just empty InlineFlowBoxes


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.