[Webkit-unassigned] [Bug 26800] New: isAncestorNode and isDescendantNode: Confusing function names

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26800

           Summary: isAncestorNode and isDescendantNode: Confusing function
                    names
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Macintosh
        OS/Version: Mac OS X 10.5
            Status: UNCONFIRMED
          Severity: Trivial
          Priority: P2
         Component: Web Inspector
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: rigdern at gmail.com


function isAncestorNode(ancestor)
It would seem that this function checks to see if "ancestor" is an ancestor of
"this." However, it checks if "ancestor" is a descendant of "this." To clarify
the meaning of the function, the function should be renamed to isAncestorNodeOf
and the parameter should be renamed to potentialDescendant like this:
function isAncestorNodeOf(potentialDescendant)

Similar changes should be made to the isDescendantNode function:
function isDescendantNodeOf(potentialAncestor)


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.