[Webkit-unassigned] [Bug 26691] Cleanup: Move focusRingColor to RenderTheme

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26691





------- Comment #12 from bfulgham at webkit.org  2009-06-27 21:30 PDT -------
(In reply to comment #11)
> I tried to be careful about breaking other ports and cc-ed everyone who seemed
> relevant, and got no response.

Sorry about that; I was on vacation and didn't notice this patch. I would have
thought
the Gtk guys might have commented but didn't see anything.

> I did check with Hyatt before starting on this patch and he seemed to think the
> current behavior was wrong and that Cairo in itself should not dictate the
> focus ring color (as was the case before this patch, as far as I can tell.

Oh, definitely. Your patch is way better than the status quo. The current
Windows/Gtk
Cairo behavior was an old kludge to get things working and has long been in
need of some refactoring.

I'll give it a shot on Monday and propose a patch if it seems to be working
strangely.  
> understand) but this should be set per-platform in the relevant RenderTheme*
> 
> Overriding focusRingColor in RenderThemeWin to restore the previous behavior
> should be straightforward, I would have done it in this patch except for the
> above.
> 


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.