[Webkit-unassigned] [Bug 26776] Write more XSSAuditor tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26776


abarth at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #31981|review?                     |review-
               Flag|                            |




------- Comment #2 from abarth at webkit.org  2009-06-27 16:49 PDT -------
(From update of attachment 31981)
Yay!  Tests === the awesome.

> +function getXMLHTTPRequest() {

> +function sendRequest(url, params, HTTPMethod) {

What's the point of these functions?  They don't seem to be used...

> +function sendRequestFromIFrame(url, params, HTTPMethod) {
> +	if (!params || params.length == 0) {
> +		return;
> +	}

Please convert all the tabs to spaces.  (Four space indent.)

> +	var iFrameObj = document.createElement('iframe');
> +	with(iFrameObj) {
> +		id = "_ffiFrame";
> +		height = "1";
> +		width = "1";
> +		style.visibility = "hidden";
> +	}

Yuck.  Please don't use |width|.  Just assign the properties of iFrameObj. 
(Also, you can use an simpler name, like frame.)


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.