[Webkit-unassigned] [Bug 3749] XHTML 1.1 Ruby Annotation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=3749


hamaji at chromium.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hamaji at chromium.org




------- Comment #11 from hamaji at chromium.org  2009-06-26 10:35 PDT -------
A few unsolicited code reviews for some style issues:

- CSSStyleSelector.cpp has some /* */ comments. Are they really necessary? If
so, adding some comments would help readers. Also, ruby.css seems to have a
line which is commented out.
- I think destructors should be virtual. Otherwise we may have resource leaks
in future.
- It would be better to add "// namespace WebCore" when you close namespaces.
- I think specialHeight() needs some comments to describe how it is special.
- For RenderRuby*::isChildAllowed, WebKit doesn't use line breaks around || , I
think.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.