[Webkit-unassigned] [Bug 20578] [CAIRO] pattern of a canvas-element changes after modifications on canvas-element

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=20578


eric at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #31764|review?                     |review-
               Flag|                            |




------- Comment #5 from eric at webkit.org  2009-06-26 03:25 PDT -------
(From update of attachment 31764)
I think this should be broken into a "copySurface" static inline.  That
function should have a comment pointing to the discussion about how cairo is
lacking this call.

Otherwise this looks great.

I think it would be nice to fix the one nit about breaking this out into its
own function with a comment about how cairo doesn't provide this natively. 
Eventually cairo is likely to provide this, and when it does, we can replace
your copySurface function with a call to the native cairo call.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.