[Webkit-unassigned] [Bug 26740] bugzilla-tool post-diff needs to obsolete old patches before posting

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26740


jmalonzo at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #31890|review?                     |review+
               Flag|                            |




------- Comment #3 from jmalonzo at gmail.com  2009-06-25 19:06 PDT -------
(From update of attachment 31890)
> +            log("Obsoleteting %s on bug %s" % (pluralize('old patch', len(patches)), bug_id))

Obsoleting :)

> -
> -            if str(review_status).find("review+") != -1:
> -                reviewer = review_status.contents[0].split(':')[0] # name:\n review+\n
> -                reviewer_full_name = self.full_name_from_bugzilla_name(reviewer)
> -                attachment['reviewer'] = reviewer_full_name
> +            attachment['is_obsolete'] = (element.has_key('isobsolete') and element['isobsolete'] == "1")
> +            attachment['is_patch'] = (element.has_key('ispatch') and element['ispatch'] == "1")

I think without '== "1"' should be fine as well.

r=me.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.