[Webkit-unassigned] [Bug 26733] Add V8 methods to notify clients about context creation/destruction

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26733


fishd at chromium.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #31877|review?(fishd at chromium.org) |review-
               Flag|                            |




------- Comment #2 from fishd at chromium.org  2009-06-25 15:58 PDT -------
(From update of attachment 31877)
> Index: WebCore/ChangeLog
...
> +        Reviewed by NOBODY (OOPS!).
> +
> +	https://bugs.webkit.org/show_bug.cgi?id=26733
> +
> +	Add V8-only methods to FrameLoaderClient that V8 can use to send
> +	out notifications when it creates/destroys a script context.

Replace tabs with spaces


> Index: WebCore/loader/FrameLoaderClient.h
...
> +#if USE(V8)
> +        virtual void didCreateScriptContext() const { }
> +        virtual void didDestroyScriptContext() const { }

I think these should be pure virtual like the other FrameLoaderClient methods.

Otherwise, LG


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.