[Webkit-unassigned] [Bug 24187] RTL: tooltip does not get its directionality from its element's directionality

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=24187





------- Comment #14 from xji at chromium.org  2009-06-25 15:12 PDT -------
Yes, you are right.
I forgot the overload part in each client.

Thanks,
Xiaomei 

(In reply to comment #13)
> (In reply to comment #12)
> > I tried the approach in Chrome before uploading the patch, and it worked. But I
> > neglected the fact that the Chrome side code *has to* be changed/re-compiled
> > after pick up this webkit patch. I was removing the review flag almost at the
> > same time when you submitted the review feedback.
> > 
> > Looks like with this patch, there is no way for webkit to avoid the
> > recompilation of other platforms.
> 
> There's no need to avoid this. All these platforms are inside WebKit for a
> reason. We can change them all at once. It does make it harder to test the fix,
> but as long as your patch changes all platforms it's completely legitimate to
> change this internal interface to add the direction argument.
> 
> You just need to actually change them all.
> 


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.