[Webkit-unassigned] [Bug 26729] New: svn-apply (and svn-create-patch) shouldn't overwrite binary files with changes since the patch

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26729

           Summary: svn-apply (and svn-create-patch) shouldn't overwrite
                    binary files with changes since the patch
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Macintosh
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: levin at chromium.org
                CC: eric at webkit.org, levin at chromium.org


When I applied https://bugs.webkit.org/attachment.cgi?id=31699 to my tree, the
patch for WebCore/English.lproj/localizedStrings.js happily applied to my tree
even though the applying the patch incorrectly undid changes.

Ideally, svn-apply would fail in this case so that the user would notice the
issue.  In my case, I was fortunately to catch the issue before checking in,
but I could have easily missed in (and in a more automated handling of the bug,
this would definitely have been missed at present).


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.