[Webkit-unassigned] [Bug 26661] Fullscreen button should be hidden when the backend doesn't support it.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26661


simon.fraser at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #31863|review?                     |review+
               Flag|                            |




------- Comment #11 from simon.fraser at apple.com  2009-06-25 11:36 PDT -------
(From update of attachment 31863)

> diff --git a/WebCore/html/HTMLMediaElement.h b/WebCore/html/HTMLMediaElement.h
> index 2a08e3c..18b263a 100644
> --- a/WebCore/html/HTMLMediaElement.h
> +++ b/WebCore/html/HTMLMediaElement.h
> @@ -65,7 +65,9 @@ public:
>      
>      virtual bool isVideo() const { return false; }
>      virtual bool hasVideo() const { return false; }
> -    
> +
> +    virtual bool supportsFullscreen() const { return false; }

Try to avoid changing whitespace.

> +void MediaControlFullscreenButtonElement::update()
> +{
> +    setHidden(!m_mediaElement->supportsFullscreen());
> +    MediaControlInputElement::update();

Will need to change when setHidden goes away.

> diff --git a/WebCore/rendering/MediaControlElements.h b/WebCore/rendering/MediaControlElements.h
> index 0c95976..4d8647e 100644
> --- a/WebCore/rendering/MediaControlElements.h
> +++ b/WebCore/rendering/MediaControlElements.h
> @@ -154,6 +154,7 @@ class MediaControlFullscreenButtonElement : public MediaControlInputElement {
>  public:
>      MediaControlFullscreenButtonElement(Document*, HTMLMediaElement*);
>      virtual void defaultEventHandler(Event*);
> +    void update();

You'll need to make update() virtual on MediaControlInputElement, then declare
if virtual here.

OK with these changes.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.