[Webkit-unassigned] [Bug 24300] Add CSSKeepVisitedLinksPrivate option to WebCore

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=24300





------- Comment #15 from robert at roberthogan.net  2009-06-25 05:44 PDT -------
(In reply to comment #14)
> (From update of attachment 31797 [review])
> (In reply to comment #13)
> > Just FYI I started out with
> > http://github.com/Arora/arora/tree/master/src/history/historymanager.cpp
> INAL, but it sounds like this patch is a derived work from the above URI and
> therefore subject to the GPL.  Are you sure you have the legal right to
> relicense the code?  (I'm pretty sure that's what you warrant when you click
> through the patch upload agreement.)

I believe I have ended up with a completely different class - in fact it is a
minimal class required to support qwebhistoryinterface. I understand that the
way I wrote the class has created ambiguity, so you are right to be cautious.

At this point the only common elements between my historymanager.cpp and the
one in Arora are:

 - the filenames
 - the name of the class (HistoryManager)

The only function names it shares with arora's are the ones that it is required
to reimplement from qwebhistoryinterface in QtWebKit in order to function -
addHistoryEntry and historyContains. The contents of both these functions is
different from the arora file.

Can you advise what I need to do dispel the whiff of sulphur here?


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.