[Webkit-unassigned] [Bug 26299] svn-[un]apply should be updated to work with git

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26299





------- Comment #10 from ddkilzer at webkit.org  2009-06-25 03:19 PDT -------
(From update of attachment 31831)
>+        I did not update svn-unapply, because it makes no sense in a Git world.
>+        You don't roll in and out patch files.  You make commits and deal with those.
>+        Git users can just git reset --hard to get the same functionality.

I think you missed the point of svn-unapply, although it still makes little
sense for git users.  Some Subversion users may have more than one patch in
their tree at the same time, e.g., working on two bugs at once (or testing two
patches together), so being able to unapply one is useful in that case.

With git, it's usually easier to create a branch for each patch, and create a
third branch for testing (with a cherry-picked commit/merged branch) if more
than one patch needs to be tested together.

>+# These should be replaced by an scm class/module:
>+sub scmKnowsOfFile($);
>+sub scmCopy($$);
>+sub scmAdd($);
>+sub scmRemove($);

VCSUtils.pm is that module.

>+my $force = 0;
>+
>+my $optionParseSuccess = GetOptions(
>+    "merge!" => \$merge,
>+    "help!" => \$showHelp,
>+    "reviewer=s" => \$reviewer,
>+    "force!" => \$force
>+);

The $force switch doesn't actually do anything.  Did you upload the wrong
patch?


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.