[Webkit-unassigned] [Bug 26703] bugzilla-tool apply-patches needs --local-commit and land-patches should support multiple bugs

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 24 23:44:59 PDT 2009


------- Comment #7 from eric at webkit.org  2009-06-24 23:44 PDT -------
(In reply to comment #4)
> (From update of attachment 31827 [review])
> > +                tool.scm().commit_locally_with_message(patch['name'])
> As discussed, the message given here doesn't seem like the right thing.

commit_message = commit_message_for_this_commit(scm)
scm.commit_locally_with_message(commit_message or patch['name'])

Which should "do the right thing" for both patches which have ChangeLogs and
those which don't.

> Consider:
>             raise ScriptError('Failed to run "%s"  exit_code: %d  cwd: %s' %
> (command, exit_code, cwd))

Considered.  And changed! ;)

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list