[Webkit-unassigned] [Bug 26659] Support hidding an control bar element from the Media element controller.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26659





------- Comment #4 from pdherbemont at apple.com  2009-06-24 16:40 PDT -------
(In reply to comment #3)
> (From update of attachment 31745 [review])
> You ChangeLog is missing the bug url.

Thanks.

> Style:
> +    if(m_isHidden)
> +    if(!m_mediaElement || !m_mediaElement->renderer())
> +    if (!renderer() && !m_isHidden && style->display() != NONE)
> +    {
> +        if (renderer)
> +        {

Thanks.

> When does this ever return NULL?
> +        RenderObject* renderer =
> createRenderer(m_mediaElement->renderer()->renderArena(), style);

That's what previous code does.

I guess it will be NULL if malloc fails basically.

> Why don't we just early-return in that case?

ok.

> Why manually set attached instead of calling attach?
> +            setAttached();

That's what previous code was doing :)

Using attach() requires some changes. And I think it deserve a separate bug.
(Basically we need to create a renderer with a specific style, so we need a to
have styleForRenderer() virtual, along with other changes).
I have created https://bugs.webkit.org/show_bug.cgi?id=26697 for that.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.