[Webkit-unassigned] [Bug 26655] ResourceHandle infrastructure is needed to support loading out of an appcache

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26655


michaeln at google.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #31813|                            |review?
               Flag|                            |




------- Comment #2 from michaeln at google.com  2009-06-24 15:16 PDT -------
Created an attachment (id=31813)
 --> (https://bugs.webkit.org/attachment.cgi?id=31813&action=view)
Interceptor (rev2)

Uploaded another stab it using the "other approach"... the wrapper class
* renamed existing ResourceHandle.h cpp --> PlatformResourceHandle.h cpp
* introduced new ResourceHandle.h cpp with same interface as existing class,
but
have it use the PlatformResourceHandle for everything
* bake ResourceHandleInterceptor usage into the new class

The good thing about this approach is that it only calls for entirely
mechanical
changes to the existing platorm specific ResourceHandle impls... simple class
name changes.

Still just looking for preliminary comments right now. An obvious thing thats
needed are test cases.

Incidentally, chrome has the moral equivalent, URLRequest::Interceptor, in
place for this already... http://codereview.chromium.org/67019... including a
decent set of test cases. I'll be looking to implement similar tests for this 
ResourceHandle Intercepor stuff.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.