[Webkit-unassigned] [Bug 26573] [Gtk] Add Undo/Redo support to WebKitGtk

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26573


jmalonzo at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #31651|review?                     |review-
               Flag|                            |




------- Comment #11 from jmalonzo at gmail.com  2009-06-24 03:20 PDT -------
(From update of attachment 31651)
> +void EditorClient::registerCommandForUndo(WTF::PassRefPtr<WebCore::EditCommand> command)
>  {
> -    notImplemented();
> +    if (undoStack.size() == maximumUndoStackDepth)
> +	undoStack.removeFirst();

Kindly fix the spacing.

>  bool EditorClient::shouldInsertNode(Node*, Range*, EditorInsertAction)
> @@ -524,6 +547,7 @@ EditorClient::EditorClient(WebKitWebView
>      : m_webView(webView)
>  {
>      WebKitWebViewPrivate* priv = m_webView->priv;
> +    isInRedo = false;

This needs to be in the initialization list.

>      class EditorClient : public WebCore::EditorClient {
> +    protected:
> +        bool isInRedo;

Member variables need to be prefixed with m_. See coding style for details.

> +
> +        typedef WTF::Deque<WTF::RefPtr<WebCore::EditCommand> > EditCommandStack;
> +        EditCommandStack undoStack;
> +        EditCommandStack redoStack;

Is the typedef necessary since you're only using EditCommandStack in these two
lines?

r- for now until those the style issues are fixed. Patch looks fine otherwise.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.